Skip to content

Update update-checkout-config.json #79117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

Update update-checkout-config.json #79117

merged 2 commits into from
Feb 20, 2025

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Feb 3, 2025

Update swift-system requirement to 1.4.0. This is motivated by swift-build which requires swift-system 1.4.0. More importantly, the API surface between 1.3.0 and 1.4.0 changed including the API usage that is required by swift-build.

@compnerd
Update update-checkout-config.json
fcd6aff 
Update swift-system requirement to 1.4.0. This is motivated by swift-build which requires swift-system 1.4.0. More importantly, the API surface between 1.3.0 and 1.4.0 changed including the API usage that is required by swift-build.
@compnerd compnerd requested a review from shahmishal as a code owner February 3, 2025 17:51
@compnerd compnerd requested review from etcwilde, shahmishal and jakepetroules and removed request for shahmishal February 3, 2025 17:51
@compnerd
Copy link
Member Author

compnerd commented Feb 3, 2025

@swift-ci please smoke test

@etcwilde
Copy link
Member

etcwilde commented Feb 4, 2025 

error: package 'swift-system' is using Swift tools version 5.9.0 but the installed version is 5.8.1

@finagolfin
Copy link
Member

May be time to update the pre-installed toolchain on the linux CI to 5.9.2?

@compnerd compnerd mentioned this pull request Feb 12, 2025
Merged
@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

1 similar comment
@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

@finagolfin
Copy link
Member

As Evan noted weeks ago, the linux CI alone fails because the updated swift-system requires Swift 5.9, error: package 'swift-system' is using Swift tools version 5.9.0 but the installed version is 5.8.1. Unless you update the pre-installed toolchain on the linux CI, it is going to keep failing with this pull.

@finagolfin finagolfin mentioned this pull request Feb 18, 2025
Closed
@compnerd
Copy link
Member Author

@finagolfin yeah, I know, I was hoping that the images might have been updated. But, seems not :(

etcwilde
etcwilde reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swiftlang/swift-build@09c975a bumped the minimum to swift-system 1.4.1. It doesn't fix the CI, but might as well download something new enough.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd compnerd merged commit db7b013 into main Feb 20, 2025
3 checks passed
@compnerd compnerd deleted the compnerd/swift-system-upgrade branch February 20, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde left review comments

@jakepetroules jakepetroules jakepetroules approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compnerd @etcwilde @finagolfin @jakepetroules