[ClangImporter][Tests] clang doesn't support the empty string as a path argument #79119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-twilightcoder
requested review from
jckarter,
zoecarver,
hyp,
egorzhdan,
beccadax and
Xazax-hun
as code owners
ian-twilightcoder
force-pushed
the
empty-search-paths
branch
from
5a7182b to
77be2e4
Compare
ian-twilightcoder
requested review from
xymus,
bnbarham,
artemcm and
tshortli
|
This test is disabled for C++ reasons too, so kind of hard to test, but I think it's pretty clear that this is the regression from #78303 |
ian-twilightcoder
force-pushed
the
empty-search-paths
branch
from
77be2e4 to
81f9cb2
Compare
…th argument SIL/verify_all_overlays.py is passing `-F ""` on non-Apple platforms. Swift handles that kind of, but clang doesn't support it and will get argument parsing errors. It's a pathological case, so fix SIL/verify_all_overlays.py to not do that, but also add a failsafe in ClangImporter to not pass on empty paths. rdar://142441042
ian-twilightcoder
force-pushed
the
empty-search-paths
branch
from
81f9cb2 to
517ced4
Compare
|
@swift-ci smoke test |
|
@swift-ci test |
artemcm
approved these changes
Feb 3, 2025
|
The docc test failures on macOS don't look to be related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIL/verify_all_overlays.py is passing
-F ""on non-Apple platforms. Swift handles that kind of, but clang doesn't support it and will get argument parsing errors. It's a pathological case, so fix SIL/verify_all_overlays.py to not do that, but also add a failsafe in ClangImporter to not pass on empty paths.rdar://142441042