[Parser] Include all AST nodes from every #if region in ParserUnit #79120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
parser-unit-ifconfig-allactive-rdar117387631
branch
from
0d09f6b to
e3fef8e
Compare
rintaro
changed the title
|
@swift-ci Please smoke test |
rintaro
requested review from
ahoppen,
bnbarham,
hamishknight,
CodaFi,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
DougGregor
reviewed
Feb 3, 2025
Yes, definitely - there's no missing functionality that I'm aware of today. But given it's not too difficult to keep existing clients working in this case, I'd rather leave this in for compatibility. |
bnbarham
approved these changes
Feb 3, 2025
rintaro
force-pushed
the
parser-unit-ifconfig-allactive-rdar117387631
branch
from
fa6c027 to
5d7752a
Compare
|
@swift-ci Please smoke test |
'ParserUnit' is used for analyzing syntax structures _mainly_ in SourceKit. Since we removed IfConfigDecl from AST, ParserUnit didn't inclue any AST in #if ... #endif regions even for active region because it used to consider all inactive. Instead, consider every region "active" and include all the AST nodes. rdar://117387631
rintaro
force-pushed
the
parser-unit-ifconfig-allactive-rdar117387631
branch
from
5d7752a to
694e815
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ParserUnit' is used for analyzing syntax structures mainly in SourceKit.
Since we removed IfConfigDecl from AST, ParserUnit didn't inclue any AST in #if ... #endif regions even for active region because it used to consider all inactive. Instead, consider every region "active" and include all the AST nodes.
rdar://117387631