Sema: Loosen more available than enclosing extension diagnostic #79122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When diagnosing a declaration that is more available than its context, to preserve source compatibility we need to downgrade the diagnostic to a warning when the outermost declaration is an extension. This logic regressed with swiftlang#77950 and my earlier attempt to fix this (swiftlang#78832) misidentified what had regressed. Really resolves rdar://143423070.
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diagnosing a declaration that is more available than its context, to preserve source compatibility we need to downgrade the diagnostic to a warning when the outermost declaration is an extension. This logic regressed with #77950 and my earlier attempt to fix this (#78832) misidentified what had regressed.
Really resolves rdar://143423070.