[NFC] Add some span unit tests for bounds check optimizations #79129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
changed the title
meg-gupta
force-pushed
the
boundstests
branch
3 times, most recently
from
c8827c0 to
9c3329f
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
boundstests
branch
from
9c3329f to
fe6085f
Compare
meg-gupta
force-pushed
the
boundstests
branch
from
fe6085f to
df6f4f2
Compare
|
@swift-ci smoke test |
atrick
approved these changes
Feb 6, 2025
| @_unsafeNonescapableResult | ||
| @inlinable @inline(__always) | ||
| @lifetime(borrow source) | ||
| public func _overrideLifetime< |
There was a problem hiding this comment.
It would be helpful to use the same syntax for _overrideLifetime everywhere. We should copy the standard library's implementation. I always spend a lot of time adapting code from @glessard because he hasn't updated his repos yet.
_overrideLifetime(_:borrowing)
_overrideLifetime(_:copying)
_overrideLifetime(_:mutating)
meg-gupta
force-pushed
the
boundstests
branch
from
df6f4f2 to
24547bb
Compare
|
@swift-ci smoke test |
meg-gupta
force-pushed
the
boundstests
branch
from
24547bb to
d8aa678
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
meg-gupta
force-pushed
the
boundstests
branch
from
d8aa678 to
3da2b90
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test windows platform |
|
I'm not sure why the PR test passed here. Attempting to fix it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add swift unit tests for testing bounds check optimizations for Span.