Sema: Fix 'super' calls from methods returning 'Self' [3.1] #7914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a quirk where TypeBase::getSuperclass() on DynamicSelfType returns the underlying class type, and not the superclass of the underlying class type. As a result, we would emit a SuperRefExpr whose type was the type of 'self' and not the type of 'super'. Fixes <rdar://problem/30853768>.
|
Hey @jckarter, you just finished a tour of duty as the dynamic Self czar -- does this fix look OK for 3.1? |
|
@swift-ci Please test |
|
Merging to push through more CI testing and to generate a downloadable snapshot, but would appreciate @jckarter's sign off. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a quirk where TypeBase::getSuperclass() on DynamicSelfType
returns the underlying class type, and not the superclass of the
underlying class type. As a result, we would emit a SuperRefExpr
whose type was the type of 'self' and not the type of 'super'.
Fixes rdar://problem/30853768 and rdar://problem/30834916.