[6.1] The SWIFT_DUMP_ACCESSIBLE_FUNCTIONS flag must be a bool, not a string #79148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
changed the title
hborla
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This flag is used in an if condition to only conditionally log some debug information (swift_once) for Distributed. Since it was a string, it was wrongly always "true" and the debug logging has happened always. This fixes the flag to be a bool and stops accidentally logging debug information.
Scope/Impact: Any Distributed adopter making a remote call.
Risk: Low, trivial fix to correct type of flag. No compatibility impact.
Testing: Manually verified the debug logging is not present
Reviewed by: @xedin
Original PR: #79147
Radar: rdar://144203699