Package CMO: Skip deserialization error checks for same-module decls. #79157
+50
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
eeckstein,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
IterableDeclContext::checkDeserializeMemberErrorInPackage recursively checks if decls and their member decls are deserialized correctly into another module. This PR adds a check to make sure the inspected decls are from another module, and provides an opt-in flag to fail fast on deserialization failure if found. rdar://143830240
elsh
force-pushed
the
elsh/pcmo-bypass-res-check-mods
branch
from
3ef5b01 to
f314d45
Compare
elsh
force-pushed
the
elsh/pcmo-bypass-res-check-mods
branch
from
f314d45 to
ee75183
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IterableDeclContext::checkDeserializeMemberErrorInPackage recursively checks if
decls and their member decls are deserialized correctly into another module.
This PR adds a check to make sure the inspected decls are from another module,
and provides an opt-in flag to fail fast on deserialization failure if found.
rdar://143830240