IRGen: Fix DenseMap interior pointer invalidation bug in IRGenSILFunction::visitEndApply. #79161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jckarter
force-pushed
the
end-apply-coroutine-iterator-invalidation
branch
from
97672d0 to
d7466e5
Compare
|
@swift-ci Please test |
|
This works, but we could also just set the lowered explosion as the last thing in the function, right? |
|
I was going for the minimal change, but I'll try that. |
…tion::visitEndApply. Fixes rdar://144216380.
jckarter
force-pushed
the
end-apply-coroutine-iterator-invalidation
branch
from
d7466e5 to
3d779cd
Compare
|
Looks like that works, so I'll go with that instead. |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://144216380.