[Debug Info] Emit -gdwarf-types debug info for Builtin.FixedArray<> #79181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test source compatibility |
|
@swift-ci test |
augusto2112
approved these changes
Feb 6, 2025
adrian-prantl
force-pushed
the
gdwarf-fixed-array
branch
from
b421a26 to
14bb4b6
Compare
|
@swift-ci smoke test |
|
test with swiftlang/llvm-project#9970 |
|
test with swiftlang/llvm-project#9970 |
|
@swift-ci test linux |
|
@swift-ci smoke test |
|
@swift-ci test macOS |
adrian-prantl
force-pushed
the
gdwarf-fixed-array
branch
from
14bb4b6 to
458dbaa
Compare
|
@swift-ci test |
Azoy
approved these changes
Feb 11, 2025
adrian-prantl
force-pushed
the
gdwarf-fixed-array
branch
3 times, most recently
from
c50ab3b to
b373a5c
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Renamed |
|
@swift-ci smoke test |
|
Linux test failure is unrelated. |
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
|
@swift-ci test windows |
|
@swift-ci smoke test |
|
@swift-ci test linux |
|
@swift-ci test linux |
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
adrian-prantl
force-pushed
the
gdwarf-fixed-array
branch
from
b373a5c to
c8db0f6
Compare
|
@swift-ci test |
|
@swift-ci smoke test |
This commit also changes how specialized types are being emitted. Previously we would not emitthe detailed member information in the specialized type itself, and instead rely on the fact that it was present in the unspecialized type, however, this wold prevent us from emitting any bound generic members, so we're now emitting the members in both variants of the type. This uncovered a with type aliases that this commit also addresses: Because we don't canonicalize types prior to caching in order to preserve type sugar, alternative representations of recursive types (with one or more levels of recursion unfolded) could create potential infinite chains of types. This is addressed by checking whether a sugared type has an already emitted canonical representation first, and if yes, creating a typedef node pointing directly to it. The donwside of doing this is that it can lead to the disappearnce of type aliases definitions when they are used as parameters in bound generic types. However, we still preserve that a type was `MyClass<MyAlias>`. We just might have a typedef pointing director from `MyClass<MyAlias>` -> `MyClass<CanonicalType>`. rdar://144315592
adrian-prantl
force-pushed
the
gdwarf-fixed-array
branch
from
c8db0f6 to
fcbebc5
Compare
|
@swift-ci test |
|
@swift-ci smoke test |
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
|
@swift-ci test |
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also changes how specialized types are being emitted. Previously we
would not emitthe detailed member information in the specialized type itself,
and instead rely on the fact that it was present in the unspecialized type,
however, this wold prevent us from emitting any bound generic members, so we're
now emitting the members in both variants of the type.