[Macros] Eliminate ordering dependency that suppressed conformingTo protocols #79195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rotocols When a macro that has both 'member' and 'extension' roles is on a type, and both list conforming protocols, the order in which those roles were evaluated in the compiler could change the set of protocols passed to the macro expansion function (via `conformingTo:`). Specifically, if the extension macro was expanded first, the member macro would see the extension providing the conformance to one of its protocols, and not pass down that protocol to the member macro's `conformingTo:`. Ensure that we account for already-expanded extension macros that define conformances. Fixes rdar://137080876.
DougGregor
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
Linux failure is unrelated |
|
@swift-ci please smoke test Linux |
hborla
approved these changes
Feb 6, 2025
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a macro that has both 'member' and 'extension' roles is on a type, and both list conforming protocols, the order in which those roles were evaluated in the compiler could change the set of protocols passed to the macro expansion function (via
conformingTo:). Specifically, if the extension macro was expanded first, the member macro would see the extension providing the conformance to one of its protocols, and not pass down that protocol to the member macro'sconformingTo:.Ensure that we account for already-expanded extension macros that define conformances.
Fixes rdar://137080876.