[NFC] Update span unit tests for bounds check optimizations #79222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
These initializers have ownership errors. Once rdar://144352938 is fixed, these can be enabled again.
meg-gupta
force-pushed
the
boundstestsupdate
branch
2 times, most recently
from
add1ba3 to
0bff081
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
boundstestsupdate
branch
from
0bff081 to
2ac449a
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -O to the compilation of SpanExtras and update check lines especially check lines for llvm's vectorization with the updated version.
Using -O during module compilation is important because of how preconditions are lowered in -Onone vs -O. Even though we run optimizations on an imported module, it is important to use -O for module compilation especially when we are analyzing optimization variations.