[cxx-interop] Fix template parameter printing scheme for const types #79237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Xazax-hun
reviewed
Feb 13, 2025
j-hui
force-pushed
the
fix-class-template-printer
branch
from
4a360c2 to
6906d27
Compare
|
@swift-ci please smoke test |
j-hui
requested review from
zoecarver,
hyp,
egorzhdan,
fahadnayyar,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
Xazax-hun
reviewed
Feb 28, 2025
|
Oops, I realized I had left a stray (Also my local tests were "succeeding" because they were unsupported 🙃) |
|
@swift-ci Please test |
egorzhdan
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the class template printer to disambiguate
const-qualified template arguments by wrapping them with__cxxConst<>, rather than suffixing them with_const.This is necessary to accommodate template arguments that aren't just identifiers (i.e.,
Foo<Int_const>is ok, butFoo<Bar<T>_const>andFoo<((Bar) -> Baz)_const>are not syntactically valid). With this patch, we would produceFoo<__cxxConst<Int>>,Foo<__cxxConst<Bar<T>>, andFoo<__cxxConst<((Bar) -> Baz)>>instead.This patch also disambiguates
volatile-qualified template arguments with__cxxVolatile<>, and changes the printing scheme forstd::nullptr_tfromnilto__cxxNullPtrT(sincenilis not a syntactically valid type name).rdar://143769901