AST: Platform-specific fixes for -unavailable-decl-optimization
#79248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One to get the active domain for the compilation target and another to get the ABI compatibility domain for a given domain. The ABI compatibility domain will be needed for queries that compute whether an unavailable declaration is still reachable at runtime. NFC.
Using availability domains, reimplement the algorithm that determines whether a declaration is unavailable at runtime. The new algorithm takes ABI compatible platforms into account, ensuring that declarations that are available on iOS do not get treated as unreachable at runtime when compiling for visionOS. Resolves rdar://116742214.
Correct the determination of whether a declaration is unreachable at runtime when compiling a zippered library. Resolves rdar://125930716.
It's no longer used after the rewrite of the algorithm for determining if a declaration is unreachable at runtime.
tshortli
force-pushed
the
abi-compatible-platform-decl-reachability
branch
from
01a035e to
670bfc0
Compare
tshortli
requested review from
hborla,
slavapestov,
xedin,
jckarter and
ktoso
as code owners
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
-unavailable-decl-optimizationon visionOS and on macOS for zippered libraries. It was previously disabled because of the complexity of correctly handling ABI compatibility with iOS in these contexts. The algorithm for determining whether a declaration is unreachable at runtime due to unavailability has been rewritten to account for platforms with ABI compatible ancestor platforms.Resolves rdar://116742214 and rdar://125930716.