Skip to content

Frontend: Remove the -skip-import-in-public-interface flag #79254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

This flag is unsafe since the compiler does not verify that the resulting public interface will compile with the module import removed. The modern alternative to this flag is @_spiOnly import. Since the flag is no longer used by any projects it should be removed.

Resolves rdar://134351088.

This flag is unsafe since the compiler does not verify that the resulting
public interface will compile with the module import removed. The modern
alternative to this flag is `@_spiOnly import`. Since the flag is no longer
used by any projects it should be removed.

Resolves rdar://134351088.
@tshortli tshortli requested a review from artemcm as a code owner February 10, 2025 02:55
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli enabled auto-merge February 10, 2025 02:55
@tshortli tshortli merged commit b185bf9 into swiftlang:main Feb 10, 2025
3 checks passed
@tshortli tshortli deleted the remove-skip-import-in-public-interface branch February 10, 2025 07:26
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants