-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[DebugInfo]Generate call-site information in swift #79308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ed1606
to
c4549d3
Compare
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
@swift-ci please test Windows |
@swift-ci please test Source Compatibility |
c4549d3
to
c1a2077
Compare
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
@swift-ci please test Windows |
c1a2077
to
cf645ff
Compare
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
@swift-ci please test Windows |
@rastogishubham How much bigger does the debug info for the stdlib get due to this change? |
IIUC, there is no smoke test command. The platform specific ones only exist for the full tests. Which in this case are probably more appropriate anyway. |
Looks like at least one test failure can be explained by swiftlang/llvm-project#10084. |
@adrian-prantl The swift stdlib went from 28 MB to 30 MB The debug info section went from 4,521,724 Bytes or about 4.5 MB to 5,196,259 Bytes or 5.2 MB, or a 15% increase |
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
@swift-ci please test Windows |
@swift-ci please smoke test macOS |
@swift-ci please test Windows |
@swift-ci please smoke test macOS |
cf645ff
to
7bf5200
Compare
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
@swift-ci please test Windows |
@adrian-prantl The patch has been updated with an option |
@swift-ci please test Windows |
7bf5200
to
21f7652
Compare
@swift-ci please test Windows |
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
This patch adds support for emitting the flag llvm::DINode::FlagAllCallsDescribed when generating LLVM IR from the Swift compiler to get call-site information for swift source code.
21f7652
to
c2c5eb1
Compare
Forgot to update the test |
@swift-ci please test Windows |
@swift-ci please smoke test Linux |
@swift-ci please smoke test macOS |
@swift-ci please smoke test Linux |
This patch adds the frontend flag
gen-callsite-info
which adds support for emitting the flagllvm::DINode::FlagAllCallsDescribed
when generating LLVM IR from the Swift compiler to get call-site information for swift source code.This will help disambiguate merged functions produced by function deduplication in the linker.