Skip to content

util: Add -Variant param to build.ps1 for building Asserts | NoAsserts. #79313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Feb 12, 2025

To facilitate building asserting and non-asserting variants of the toolchain, introduce -Variant so callers can specify.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of naming, this seems reasonable to me. Thanks for wiring this up!

@jeffdav jeffdav force-pushed the win-toolchain-variants branch from 61efbf8 to a7ec9e1 Compare February 12, 2025 17:18
@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member

@swift-ci please test Windows platform

@compnerd
Copy link
Member

@swift-ci please smoke test

@jeffdav jeffdav force-pushed the win-toolchain-variants branch from c9a52d5 to 720ce16 Compare February 13, 2025 17:20
@compnerd
Copy link
Member

@swift-ci please smoke test

@jeffdav jeffdav force-pushed the win-toolchain-variants branch from 720ce16 to e5759f7 Compare February 14, 2025 01:02
@compnerd
Copy link
Member

@swift-ci please smoke test

1 similar comment
@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member

@swift-ci please smoke test

@jeffdav jeffdav force-pushed the win-toolchain-variants branch from 1654522 to 0c7fbc7 Compare February 18, 2025 03:08
@jeffdav
Copy link
Contributor Author

jeffdav commented Feb 18, 2025

@compnerd rebased on your latest changes and merged.

@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-corelibs-foundation#5174

@swift-ci please smoke test Linux platform

@compnerd compnerd enabled auto-merge (squash) February 20, 2025 22:50
@compnerd compnerd merged commit b44367e into swiftlang:main Feb 21, 2025
3 checks passed
@jeffdav jeffdav deleted the win-toolchain-variants branch March 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants