TypeResolution: Stop resolving unqualified protocol type aliases to DependentMemberType in structural stage
#79322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test Linux |
|
(FWIW: this is only for unqualified references to protocol type aliases. Something like |
|
Also let's run source compat for changes like this! |
|
@swift-ci Please test source compatibility |
AnthonyLatsis
changed the title
DependentMemberType in structural stageDependentMemberType in structural stage
…DependentMemberType` in structural stage This workaround is no longer needed because `TypeAliasType` is now modeled using generic arguments (as opposed to a substitution map). Previously, computing the substitution map in `StructuralTypeRequest` to construct the resulting `TypeAliasType` could cause a request cycle around generic signature computation.
AnthonyLatsis
force-pushed
the
charcharadon-carcharias
branch
from
5edc3c0 to
f3183be
Compare
|
Source compat succeeded: https://ci.swift.org/job/swift-PR-source-compat-suite-macos/2193/ Force-pushing to amend commit message. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround is no longer needed because
TypeAliasTypeis now modeled using generic arguments vs. a substitution map. Previously, computing the substitution map inStructuralTypeRequestto construct the resultingTypeAliasTypecould cause a request cycle around generic signature computation.