[cxx-interop] Remove some duplicated lookups #79324
Merged
+45
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
adrian-prantl,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
egorzhdan
reviewed
Feb 13, 2025
| auto known = ImportedMacros.find(name); | ||
| if (known == ImportedMacros.end()) { | ||
| auto [known, inserted] = ImportedMacros.try_emplace( | ||
| name, SmallVector<std::pair<const clang::MacroInfo *, ValueDecl *>, 2>{}); |
There was a problem hiding this comment.
Can we use something like auto here to avoid repeating the type name?
There was a problem hiding this comment.
Unfortunately, I could not avoid naming the type here because the value for try_emplace is taking a template so there is no context to deduce the type of this SmallVector from.
Repeatedly lookup up a key from a dictionary can be justified whenever the content of the dictionary might change between the lookups (so any references into the dictionary might get invalidated). We had a couple of instances where as far as I can tell no such modifications should happen between two lookups with identical keys. This PR simplifies the code to remove the extra lookups. It also removes a dictionary that was completely unused.
Xazax-hun
force-pushed
the
gaborh/redundant-lookups
branch
from
da5e498 to
068815c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly lookup up a key from a dictionary can be justified whenever the content of the dictionary might change between the lookups (so any references into the dictionary might get invalidated). We had a couple of instances where as far as I can tell no such modifications should happen between two lookups with identical keys. This PR simplifies the code to remove the extra lookups. It also removes a dictionary that was completely unused.