[AST] Explicitly cast uint64_t to size_t for 32-bit platforms
#79340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few places in the AST where we use `uint64_t` as `ArrayRef`'s size type. Even though of these `uint64_t` size fields are actually defined as bitfields with a maximum value of 32, but unfortunately it's not taken into account and clang complains about the implicit cast. The same attempt was made in 073905b, but several new places were added since then.
kateinoigakukun
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
37 tasks
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places in the AST where we use
uint64_tasArrayRef's size type. Even though of theseuint64_tsize fields are actually defined as bitfields with a maximum value of 32, but unfortunately it's not taken into account and clang complains about the implicit cast.The same attempt was made in 073905b, but several new places were added since then.
This is a part of work to port the compiler to Emscripten platform.