Do not use os._exit when build-script fatal errors
#79365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
This keeps the same behavior, which TBH I'm not sure is all that intentional. Presumably the In any case, I just want to fix errors not being output when they should be today and this at least fixes that. |
ahoppen
approved these changes
Feb 14, 2025
etcwilde
approved these changes
Feb 14, 2025
`os._exit` does not run any cleanup handlers or flush any buffers, which means that we may end up missing helpful log output. It was being used to avoid printing the log analysis when `--help` was passed, but we can have the same behavior by just not using `finally`.
bnbarham
force-pushed
the
build-script-error
branch
from
cdac8d8 to
48422f7
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os._exitdoes not run any cleanup handlers or flush any buffers, which means that we may end up missing helpful log output. It was being used to avoid printing the log analysis when--helpwas passed, but we can have the same behavior by just not usingfinally.