[6.1][Distributed] Improve getting return type metadata for distributed invocations #79386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vocations rdar://141313340
|
@swift-ci please test |
|
@swift-ci please test |
mikeash
approved these changes
Feb 17, 2025
hborla
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The way type metadata is obtained in
swift_func_getReturnTypeInfomay result in partial metadata be returned, which can result in a zero size buffer allocation, which then is going to be too small to fit a write of the result data, leading to a crash if this partial metadata was returned. This patch corrects how we obtain the metadata so we always get complete information.Scope/Impact: Very rarely an incomplete metadata may have been obtained from
swift_func_getReturnTypeInfocausing a crash as the result would then not fit the allocated result buffer.Risk: Low, the fix is local to distributed returns and definitely correct (same as some other method nearby)
Testing: Reproduced exact issue in new test, tracked down root cause with logging in applications
Reviewed by: @mikeash
Original PR: #79381
Radar: rdar://141313340