Skip to content

[6.1] Disable the crash in non-asserts builds when closures don't have a discriminator #79402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2025
Merged

[6.1] Disable the crash in non-asserts builds when closures don't have a discriminator #79402

merged 1 commit into from
Feb 15, 2025

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Feb 14, 2025 •
edited
Loading

@DougGregor
Disable the crash in non-asserts builds when closures don't have a di…
c44cb52 
…scriminator

We found another case where we aren't getting a closure discriminator,
so disable this again in non-asserts builds while we investigate.
Tracked by rdar://143590572.
@DougGregor DougGregor requested a review from a team as a code owner February 14, 2025 21:48
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor enabled auto-merge February 14, 2025 22:03
@DougGregor DougGregor merged commit c2a0cc7 into swiftlang:release/6.1 Feb 15, 2025
5 checks passed
@DougGregor DougGregor deleted the disable-closure-discriminator-check-noasserts-6.1 branch February 15, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @hborla