[Macros] Recognize the $e Embedded Swift prefix in MacroDecl::isUniqueMacroName #79403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
rintaro,
phausler,
DougGregor,
rauhul,
zoecarver,
eeckstein and
dschaefer2
kubamracek
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
DougGregor
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the attached test case. With the new Embedded Swift's mangling that uses $e as the prefix, we were failing to recognize macro-generated unique names, and rejecting them with "... is not covered by macro" if we were expanding macros while compiling in Embedded Swift mode. This fixes that.