Fix runtime default variable naming #79405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Feb 14, 2025
etcwilde
commented
Feb 14, 2025
etcwilde
force-pushed
the
ewilde/fix-runtime-defaults
branch
from
e98ea05 to
e0ded0a
Compare
|
@swift-ci please smoke test |
The names of the variables in `DefaultSettings` should end in `_default` so that the variable that they are defaulting can be overridden. Otherwise CMake will just set the value and move on overriding the setting coming from the commandline/cache file.
etcwilde
force-pushed
the
ewilde/fix-runtime-defaults
branch
from
e0ded0a to
8fe9c09
Compare
|
@swift-ci please smoke test |
edymtt
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of the variables in
DefaultSettingsshould end in_defaultso that the variable that they are defaulting can be overridden. Otherwise CMake will just set the value and move on overriding the setting coming from the commandline/cache file.