[ConstraintSystem] Always choose an available type eraser type. #79406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no available type eraser type exists, do not perform type erasure. If multiple type erasers exist, choose the least available type eraser type. Which type eraser to choose is based on the availability of the lexical context of the erased expression.
|
@swift-ci please smoke test |
tshortli
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no available type eraser type exists, do not perform type erasure. If multiple available type erasers exist, choose the least available type eraser type. The type eraser type's availability is compared against the availability within the lexical context of the erased expression to determine whether the type eraser type is available.
There may be better approaches, such as leveraging SE-0360: Opaque result types with limited availability to choose the type eraser type at runtime, but this minimal change at least lets a type eraser type be replaced without causing runtime crashes when that new type is not available at runtime.
Resolves: rdar://144572195