Tests: Stop referring to the Span feature since it has been removed #79415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
j-hui and
fahadnayyar
as code owners
|
@swift-ci please smoke test |
DougGregor
approved these changes
Feb 16, 2025
| @@ -21,7 +21,6 @@ add_swift_target_library(swiftCxx STATIC NO_LINK_NAME IS_STDLIB IS_SWIFT_ONLY | |||
|
|
|||
| SWIFT_COMPILE_FLAGS ${SWIFT_RUNTIME_SWIFT_COMPILE_FLAGS} ${SWIFT_STANDARD_LIBRARY_SWIFT_FLAGS} | |||
| -cxx-interoperability-mode=default | |||
| -enable-experimental-feature Span | |||
There was a problem hiding this comment.
I didn't do this change because I was thinking that an older compiler could encounter this usage of Span and complaint.
There was a problem hiding this comment.
That's a good point, but I think we have to preserve the experimental feature as a known feature identifier then, because otherwise it's not actually printed in the interface
There was a problem hiding this comment.
Nevermind, looks like it should still be printed. Brought it back here: #79419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI fallout from #79399.
Resolves rdar://144919269.