AST: Type-check @available attributes before synthesizing CaseIterable
#79423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able`. An `AvailableAttr` written in source with an unrecognized availability domain is now only marked invalid after type-checking the attribute. This resulted in a regression where `CaseIterable` synthesis was blocked incorrectly under the following very narrow circumstances: 1. Every `@available` attribute on the elements of the enum is invalid. 2. The module is being emitted and lazy type-checking is enabled. 3. The enum is public and the only top-level declaration in the file. Type-checking the attribute was delayed just enough that it would not be considered invalid by the type the `CaseIterable` conformance was being synthesized, resulting in a spurious error. There were zero tests exercising `CaseIterable` synthesis for enums with elements that have availability requirements, so I added some. Resolves rdar://144897917.
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin and
jckarter
as code owners
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
AvailableAttrwritten in source with an unrecognized availability domain is now only marked invalid after type-checking the attribute. This resulted in a regression whereCaseIterablesynthesis was blocked incorrectly under the following very narrow circumstances:@availableattribute on the elements of the enum is invalid.Type-checking the attribute was delayed just enough that it would not be considered invalid by the time the
CaseIterableconformance was being synthesized, resulting in a spurious error.There were zero tests exercising
CaseIterablesynthesis for enums with elements that have availability requirements, so I added some.Resolves rdar://144897917.