[ASTGen] Generate LifetimeAttr #79427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
astgen-lifetimeattr
branch
from
df0047d to
d7c0487
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Feb 17, 2025
rintaro
force-pushed
the
astgen-lifetimeattr
branch
from
d7c0487 to
2a8193d
Compare
|
@swift-ci Please smoke test |
No reason to keep the name as a StringRef
rintaro
force-pushed
the
astgen-lifetimeattr
branch
from
2a8193d to
b729746
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make
swift::LifetimeDescriptorhold anIdentifierinstead ofStringRefbecause there's no good reason forStringRef