[AST] Progress toward handling indirect conformances in witness tables #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a protocol requirement element within a requirement source, track both the protocol in which the requirement was introduced as well as the dependent type (relative to that protocol) on which the requirement was introduced. This information is important when reconstructing the path from a requirement-as-written to the location of a desired protocol conformance.
Reimplement these methods, making use of Type::subst() for the former and the stored protocol conformances that correspond to the protocol's requirement signature for the latter. This is enough to emit witness tables with indirect conformance requirements in them.
|
Adding this to the new test: will assert in access-path computation because we're not using requirement sources there. |
|
@swift-ci please smoke test and merge |
|
@rjmccall you'll be interested in this. |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some progress toward handling "indirect conformances", e.g., those that are introduced via
whereclauses on associated types, in IRGen. This currently has two independent pieces:NormalProtocolConformance::getAssocated{Type|Conformance}to make them handle indirect conformances properly.The second part lets us emit witness tables involving indirect conformances, but we need to wire up the first part before we can actually use them.