[6.1][Concurrency] Fix a few issues with matching any Sendable to Any
#79430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading-dot syntax `GenericArgumentsMismatchFailure` missed a case where location of the failure points to a member spelled with leading-dot syntax.
…whether access is mutating or not Otherwise `inout` uses of declarations that require ABI safe conversions are going to be diagnosed as non-mutating. (cherry picked from commit ff5e2dd)
|
@swift-ci please test |
…positions It should be possible to pass values with `any Sendable` as arguments to `inout` parameters that expect `Any`. This is pretty much the same as an l-value conversion. Resolves: swiftlang#79361 Resolves: rdar://144794132 (cherry picked from commit 484e0a7)
…expressions This expands swiftlang#77510 to base expressions of calls, subscripts and members to make sure that if the base has `@preconcurrency` declaration at some level. Otherwise, the availability checker won't appropriately downgrade unavailable `Sendable` conformances for `@preconcurrency` declarations. (cherry picked from commit aa0b356)
…ignments If destination is marked as `@preconcurrency` the Sendable conformance errors should be downgraded to warnings even in Swift 6 mode just like for member and subscript references. (cherry picked from commit f474588)
xedin
force-pushed
the
more-Sendable-to-Any-problems-6.1
branch
from
5412e2b to
0a237ae
Compare
|
@swift-ci please test |
xedin
changed the title
any Sendable to Anyany Sendable to Any
hborla
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #79382 and #78789
Explanation:
Allows
Anyto be matched againstany Sendablewhen it appears in generic argument position of a valuepassed as an
inoutargument (both explicit and implicit).Downgrades a few Sendable conformance diagnostics to warnings in Swift 6 mode when base of a member reference or assignment destination are marked as
@preconcurrency.A minor diagnostic improvement for generic argument mismatch with leading-dot syntax.
Main Branch PRs: [Concurrency] Fix a few issues with
SenableandAny#79382 and [Diagnostics] Fix generic arguments mismatch diagnostic related to le… #78789Risk: Low (allows some code that previously was rejected by the compiler to type-check successfully).
Resolves: rdar://144794132
Reviewed By: @hborla
Testing: Added new tests to the Concurrency/SILGen and Interprete test suites.
(cherry picked from commit 00fe563)