[cxx-interop] Remove a feature flag #79432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeInterop was guarding whether we import certain foreign types as unsafe. Since these attrbutes are only considered when an opt-in strict language mode is on, this PR removes this feature flag. We still rely on the presence of the AllowUnsafeAttribute flag to add the unsafe attributes to the imported types and functions.
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
j-hui,
fahadnayyar,
beccadax,
ian-twilightcoder,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci please smoke test |
j-hui
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeInterop was guarding whether we import certain foreign types as unsafe. Since these attrbutes are only considered when an opt-in strict language mode is on, this PR removes this feature flag. We still rely on the presence of the AllowUnsafeAttribute flag to add the unsafe attributes to the imported types and functions.