[SE-0458] Unify escapability inference for AST and Interop #79434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interop is injecting escapability annotations for the STL and doing a limited inference for aggregates. Let's reuse the same facilities in the AST when we calculate the safety of the foreign types.
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
j-hui,
fahadnayyar,
hborla,
slavapestov and
xedin
as code owners
Xazax-hun
changed the title
|
@swift-ci please smoke test |
DougGregor
approved these changes
Feb 17, 2025
| argToCheck.second); | ||
| if (nonPackArg.getKind() != clang::TemplateArgument::Type && | ||
| desc.impl) { | ||
| desc.impl->diagnose(loc, diag::type_template_parameter_expected, |
There was a problem hiding this comment.
If we're okay with disabling these diagnostics when we don't have the impl on hand, should we just remove them entirely?
There was a problem hiding this comment.
I think we should refactor this code at some point. When we import these types we will always have the impl at hand. After they are imported, we no longer need to emit diagnostics about these types so we don't really need the impl. That being said a better design would be to return some information about the diagnostics that needs to be emitted (instead of having a side effect) and only consume those in the importer and ignore them in other parts of the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interop is injecting escapability annotations for the STL and doing a limited inference for aggregates. Let's reuse the same facilities in the AST when we calculate the safety of the foreign types.