[ASTGen] Handle reasync and rethrows #79441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi and
hamishknight
as code owners
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Feb 17, 2025
rintaro
force-pushed
the
astgen-reasync-rethrows
branch
from
56255f0 to
00999cb
Compare
Introduce generate(functionSignature:for:)
rintaro
force-pushed
the
astgen-reasync-rethrows
branch
from
00999cb to
f172725
Compare
rintaro
commented
Feb 18, 2025
| func testRethrows() { | ||
| rethrowingFn { _ = 1 } | ||
|
|
||
| // FIXME: Assertion failed: (isAsync()), function getAsyncContext, file GenCall.cpp, line 215. |
There was a problem hiding this comment.
This FIXME applies to non-ASTGen as well.
|
@swift-ci Please smoke test |
|
We should just remove ‘reasync’ entirely, it’s dead code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
generate(functionSignature:for:)