Skip to content

Sema: Add missing space to Copyable conformance suppression fix-it #79445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coffmark
Copy link
Contributor

Changes

When I use fix-it to conform to ~Copyable, there's no space between ~Copyable and an open brace.

In this PR, I improved to add a space between ~Copyable and an open brace.

// Before
struct S {
  deinit { }
}
// apply for fix-it
struct S : ~Copyable{
  deinit { }
}
// apply for fix-it (this pr)
struct S : ~Copyable {
  deinit { }
}

Issue

Issue: None.

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test macOS

@AnthonyLatsis AnthonyLatsis self-assigned this Feb 19, 2025
@AnthonyLatsis
Copy link
Collaborator

Neat, thanks!

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test Linux

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test Windows

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Feb 20, 2025

@coffmark I would really appreciate if you amended the commit title (not the PR title) to be a bit more specific. For example: Sema: Add missing space to Copyable conformance suppression fix-it.

@AnthonyLatsis
Copy link
Collaborator

In case you need a hint, git commit --amend, then push with --force.

@coffmark coffmark force-pushed the fix/qoi-for-conformance-to-non-copyable branch from a048f5f to cc6f1a1 Compare February 24, 2025 23:49
@coffmark
Copy link
Contributor Author

@AnthonyLatsis
I apologize for the delay in making the corrections.
(Thanks also for the hints !)

@AnthonyLatsis
Copy link
Collaborator

No worries, I only wanted to reaffirm that you are welcome to ask for help. Thanks!

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis changed the title [QoI] Improvements for conformance to ~Copyable Sema: Add missing space to Copyable conformance suppression fix-it Feb 25, 2025
@AnthonyLatsis AnthonyLatsis merged commit e6639f1 into swiftlang:main Feb 25, 2025
3 checks passed
@coffmark coffmark deleted the fix/qoi-for-conformance-to-non-copyable branch February 25, 2025 10:28
@AnthonyLatsis AnthonyLatsis removed their assignment Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants