IRGen: adjust addressability of the generic metadata #79448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building on Windows, if the nominal base type is in a non-static library, we cannot reference the type descriptor directly. As a load is required, we cannot statically initialise the pattern metadata. Account for this in the addressability computation.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Seems like a reasonable fix to me. If you can't have statically initialized pre-specialized metadata you can't have it. (In theory one could come up with a scheme where an accessor function initializes these fields but I don't see the complexity being worth the effort to save what -- the malloc call over memory that has to be dirtied anyway?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on Windows, if the nominal base type is in a non-static library, we cannot reference the type descriptor directly. As a load is required, we cannot statically initialise the pattern metadata. Account for this in the addressability computation.
Fixes: #79417