Skip to content

Remove "unsafe" keyword from expressions when printing inlinable code #79462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

DougGregor
Copy link
Member

To help older compilers that don't yet support the unsafe expression deal with the Swift interface files we produce, remove the "unsafe" from expressions in inlinable code.

To help older compilers that don't yet support the unsafe expression
deal with the Swift interface files we produce, remove the "unsafe" from
expressions in inlinable code.
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor requested a review from tshortli February 18, 2025 17:40
Copy link
Contributor

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I love how simple it is to accomplish this with the SwiftSyntax-based inlinable text extraction.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Windows

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor DougGregor enabled auto-merge February 19, 2025 16:18
@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

2 similar comments
@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor DougGregor merged commit 052958e into swiftlang:main Feb 20, 2025
3 checks passed
@DougGregor DougGregor deleted the remove-unsafe-from-inline branch February 20, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants