[6.1] Sema: don't use llvm::StringSwitch for runtime function names
#79472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
bnbarham
approved these changes
Feb 18, 2025
xedin
approved these changes
Feb 18, 2025
drodriguez
reviewed
Feb 19, 2025
Using `llvm::StringSwitch` with this many cases causes clang to crash due to a stack overflow. Works around rdar://143944155 (cherry picked from commit ed4863f)
xedin
force-pushed
the
fix-typecheckattr
branch
from
44dd4df to
922f7b1
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
llvm::StringSwitchwith this many cases causes clang to crash due to a stack overflow. Works around rdar://143944155(cherry picked from commit ed4863f)
--- CCC ---
Explanation: clang 16.0 is often used to build release branches but crashes with infinite recursion when compiling TypeCheckAttr.cpp with asserts enabled. We need an asserts compiler to debug Swift 6.1 issues.
Scope: No functional change. This is a syntax workaround to avoid crashing clang.
Radar/SR Issue: rdar://143944155 (clang crashes compiling TypeCheckAttr.cpp when building the swift compiler: infinite recursion in EmitCXXConstructorCall)
Original PR: #79109
Risk: Minimal
Testing: clang 16.0 successfully builds
Reviewer: Pavel Yaskevich