[TypeChecker/NameLookup] SE-0463: A few fixes for SendableCompletionHandlers feature
#79478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
xedin
force-pushed
the
sendable-completion-handler-fixes
branch
from
f858d63 to
bbe2e1c
Compare
|
@swift-ci please test |
xedin
force-pushed
the
sendable-completion-handler-fixes
branch
from
bbe2e1c to
7e0996c
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
xedin
commented
Feb 19, 2025
|
@swift-ci please test Linux platform |
xedin
force-pushed
the
sendable-completion-handler-fixes
branch
from
7e0996c to
aa1c79d
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
beccadax
requested changes
Feb 21, 2025
…` in parameter positions Just like for protocol matching, let's allow `@Sendable` mismatches in parameter positions to make sure that it's possible for header authors to add concurrency annotations without breaking clients. This is especially important for `SendableCompletionHandlers` feature that makes imported sync completion handler parameters `@Sendable`.
…s ObjC/@objc declarations When `SendableCompletionHandlers` feature is enabled, ClangImporter is going to inject `@Sendable` attribute into the completion handler parameter's function type. We need to make sure that his new behavior doesn't break shadowing rules and allow APIs to annotate their ObjC declarations with `@Sendable` without breaking clients.
xedin
force-pushed
the
sendable-completion-handler-fixes
branch
from
aa1c79d to
0004a4b
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
beccadax
approved these changes
Feb 22, 2025
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility release |
1 similar comment
|
@swift-ci please test source compatibility release |
|
@swift-ci please test source compatibility |
…esults All of the declarations returned by dynamic `AnyObject` lookup are `@objc` and hence `@preconcurrency` which means that it should be possible to introduce `@Sendable` and `any Sendable` annotations without affecting lookup and shadowing behavior.
|
@swift-ci please test |
xedin
force-pushed
the
sendable-completion-handler-fixes
branch
from
332c3ca to
15a0e5a
Compare
|
@swift-ci please test |
xedin
changed the title
SendableCompletionHandlers featureSendableCompletionHandlers feature
…tnesses Witness checking itself is allowed to skip `@Sendable` mismatch in this situation. This is a narrow fix for `SendableCompletionHandlers` feature to make sure that the behavior doesn't change for non-ObjC witnesses
… on ObjC declarations Refactors `@_dynamicReplacement` attribute verification to consider only exact matches first, and if there are none, attempt to strip away sendability on ObjC declarations to make sure that any new `@Sendable` or `any Sendable` introduced to `@precocurrency` declarations don't break the overload selection.
xedin
force-pushed
the
sendable-completion-handler-fixes
branch
from
15a0e5a to
bb247d7
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
@objc @implementationto mismatch on@Sendablein parameter positionsWarn about missing
@Sendableannotations (even in Swift 6 language mode) to give users and developers time to adopt Swift concurrency.Shadowing: strip
@Sendableannotations for declarations ObjC/@objc declarations to avoid ambiguities until shadowing declarations adopt@Sendable.Strip Sendable while processing AnyObject lookup results
Allow associated type inference to skip
@Sendableon ObjC witnessesFix
@_dynamicReplacementto skip sendable annotations on ObjC declarationsResolves: rdar://85569247