Set Swift language version to 5 #79499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
shahmishal,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
tshortli
approved these changes
Feb 19, 2025
etcwilde
force-pushed
the
ewilde/apple-swift-version-5
branch
from
d7e42b0 to
94995b7
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Feb 19, 2025
|
This was previously being set on all platforms - should we just default this globally rather than squirrel it away in a cache file? |
etcwilde
force-pushed
the
ewilde/apple-swift-version-5
branch
from
94995b7 to
996e65e
Compare
The stdlib needs to build in Swift-5 mode, and ensure that `-swift-verion 5` be included in the commandline explicitly. While the compiler defaults to 5 mode, if it's not included explicitly, it won't be included in the swift interface, which then means that modules that import it will influence how the textual interface is processed. The interface for the stdlib must be processed in the Swift 5 language mode due to sendability. Set it explicitly to ensure that importing modules do not change the Swift language mode. Fixes: rdar://145118843
etcwilde
force-pushed
the
ewilde/apple-swift-version-5
branch
from
996e65e to
ebc0a37
Compare
|
@swift-ci please smoke test |
shahmishal
approved these changes
Feb 20, 2025
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swift version impacts how swift interfaces work so it's important that we set this explicitly on Apple platforms. Setting it explicitly now.
rdar://145118843