Skip to content

[Frontend] Rename NonIsolatedAsyncInheritsIsolationFromContext feature and add a feature for @execution #79508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

[Frontend] Rename NonIsolatedAsyncInheritsIsolationFromContext feature and add a feature for @execution #79508

merged 2 commits into from
Feb 21, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 20, 2025

  • NonIsolatedAsyncInheritsIsolationFromContext -> AsyncCallerExecution
  • Hide @execution attribute behind an experimental feature ExecutionAttribute

@xedin
[Frontend] NFC: Rename NonIsolatedAsyncInheritsIsolationFromContext…
e2ff330 
… feature

New name is `AsyncCallerExecution` as stated by the proposal.
@xedin
Copy link
Contributor Author

xedin commented Feb 20, 2025

@swift-ci please test

@xedin xedin requested a review from gottesmm February 20, 2025 04:04
@xedin xedin force-pushed the feature-proof-execution-attrs branch from 11336f6 to 735b3c4 Compare February 20, 2025 06:57
@xedin
Copy link
Contributor Author

xedin commented Feb 20, 2025

@swift-ci please test

@xedin
[Frontend] Hide @execution attribute behind an experimental feature…
dd1be8f 
… `ExecutionAttribute`

Since the proposal has not been approved yet we cannot expose
`@execution` attribute.
@xedin xedin force-pushed the feature-proof-execution-attrs branch from 735b3c4 to dd1be8f Compare February 20, 2025 08:05
@xedin
Copy link
Contributor Author

xedin commented Feb 20, 2025

@swift-ci please test

@xwu
Copy link
Collaborator

xwu commented Feb 20, 2025

Can we hold off on renaming the experimental feature flag in the middle of the proposal review period (imminently starting) as we would want users to be able to try it out using the instructions they're given.

@hborla
Copy link
Member

hborla commented Feb 20, 2025

Can we hold off on renaming the experimental feature flag in the middle of the proposal review period (imminently starting) as we would want users to be able to try it out using the instructions they're given.

I asked for this change to be made specifically for the review so that there are two separate flags for 1. the additive features and 2. the default change. We should just build a toolchain on this PR.

@hborla
Copy link
Member

hborla commented Feb 20, 2025

@swift-ci please build toolchain

@hborla
Copy link
Member

hborla commented Feb 20, 2025

@xwu I think it's fine to kick off the review and note that the toolchain will come today - I'll update the thread with the toolchain and the flags once it's built

@xedin
Copy link
Contributor Author

xedin commented Feb 20, 2025

@swift-ci please build toolchain Windows platform

@xedin
Copy link
Contributor Author

xedin commented Feb 20, 2025 •
edited
Loading

Toolchains:

@xedin
Copy link
Contributor Author

xedin commented Feb 21, 2025

Windows toolchain is failing with an unrelated error:

TestFoundation/TestNSData.swift:466: error: TestNSData.test_base64EncodeDoesNotAddLineSeparatorsWhenStringFitsInLine : XCTAssertEqual failed: ("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA


") is not equal to ("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA") - each 3 byte is converted into 4 characterss. 48 / 3 * 4 <= 64, therefore result should not have line separator.

TestFoundation/TestNSData.swift:472: error: TestNSData.test_base64EncodeDoesNotAddLineSeparatorsWhenStringFitsInLine : XCTAssertEqual failed: ("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA


") is not equal to ("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA") - each 3 byte is converted into 4 characterss. 57 / 3 * 4 <= 76, therefore result should not have line separator.

@xedin
Copy link
Contributor Author

xedin commented Feb 21, 2025

@swift-ci please build toolchain windows

@xedin xedin merged commit 520c05b into swiftlang:main Feb 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@xymus xymus Awaiting requested review from xymus xymus is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xedin @xwu @hborla @ktoso