Skip to content

[cxx-interop] Support ObjC classes in generic context in reverse interop #79514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Xazax-hun
Copy link
Contributor

We have the sufficient type metadata on the Swift side so this PR only makes sure the type traits are correctly generated.

rdar://145211212

@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Feb 20, 2025
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We have the sufficient type metadata on the Swift side so this PR only
makes sure the type traits are correctly generated.

rdar://145211212
@Xazax-hun Xazax-hun force-pushed the gaborh/objc-in-generics branch from 35b7271 to a6c6a00 Compare February 20, 2025 15:19
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

@Xazax-hun Xazax-hun enabled auto-merge February 20, 2025 15:29
@Xazax-hun Xazax-hun merged commit 3f88561 into main Feb 20, 2025
3 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/objc-in-generics branch February 20, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants