[Observation] Reduce the scope of the observation shouldNotifyObservers
to only apply to observation and not side effects of accessors like willSet or didSet
#79518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a degenerate case which a developer may have relied on a side effect of a didSet that has a repetitious value. This restores that case such that properties in the form:
When setting
foo = 3
and then setting it againfoo = 3
now restores the behavior of printing "applied" twice. This still leaves observation informing a change once.