-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Update benchmark readme with info on how to ensure benchmarks test locally built stdlib #79528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmark readme with info on how to ensure benchmarks test locally built stdlib #79528
Conversation
The easiest way to run the benchmarks - actually: compare two benchmark builds - is to use the |
@eeckstein can you please help me trigger necessary CI checks so that this PR becomes mergeable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Could you reformat these additions to stick to the 80 chars per line limit?
Co-authored-by: Anthony Latsis <[email protected]>
Co-authored-by: Anthony Latsis <[email protected]>
@swift-ci please smoke test |
I recently tried to run modify stdlib and run benchmarks, but I had issues with it, and readme was not helpful enough.
This PR adds a bit of info to readme to help future readers.
Problems addressed:
- error: cannot find '_wordIndex' in scope
.../lib/swift
. So the two env variables helped me solve the problem.Special thanks to @Catfish-Man for helping with these.