[CS] Clean up pack expansion environment handling a little #79529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO "environment" is confusable for GenericEnvironment, make it clearer it's referring to the parent PackExpansionExpr.
Resolve a couple of FIXMEs by using `dumpAnchor` to dump a couple of ASTNodes. This uses the same compact representation as used in ConstraintLocator dumping.
- Track environments for `PackExpansionExpr` directly instead of using a locator. - Split up the querying and creation of the environment such that the mismatch logic can be done directly in CSSimplify instead of duplicating it. - Just store the environment directly instead of the shape and UUID.
hamishknight
requested review from
hborla,
xedin and
slavapestov
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
slavapestov
approved these changes
Feb 20, 2025
| // FIXME: Print short form of ASTNode | ||
| out << "(RecordedContextualInfo)\n"; | ||
| out << "(RecordedContextualInfo "; | ||
| dumpAnchor(Node.Node, &SM, out); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackExpansionExprdirectly instead of using a locator.Should be NFC