[SourceKit] Do not hardcode the XPC service name #79530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
bnbarham
force-pushed
the
load-service-from-file
branch
from
4c57c2f to
015af23
Compare
|
@swift-ci please test macOS platform |
hamishknight
approved these changes
Feb 21, 2025
bnbarham
force-pushed
the
load-service-from-file
branch
from
015af23 to
af5d918
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Feb 22, 2025
bnbarham
force-pushed
the
load-service-from-file
branch
from
af5d918 to
95317fd
Compare
|
@swift-ci please test |
Write the service name into a resource file rather than have it hardcoded, allowing it to be updated post-build if necessary.
bnbarham
force-pushed
the
load-service-from-file
branch
from
95317fd to
652da55
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write the service name into a resource file rather than have it hardcoded, allowing it to be updated post-build if necessary.