Skip to content

utils: cleanup compares against null in build.ps1 #79533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Feb 21, 2025

These comparisons generate warnings if $null isn't on the left side. PowerShell evaluates empty strings, $null, and numeric values of 0 to false, so these comparisons aren't necessary. Also tighten up some syntax for readability.

@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd compnerd enabled auto-merge (squash) February 21, 2025 02:43
@compnerd compnerd merged commit 3115f38 into swiftlang:main Feb 21, 2025
3 checks passed
@jeffdav jeffdav deleted the build-cleanup branch March 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants