Windows; improve SDK overlay for WinSDK #79539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the style to match Swift's style.
Conditionalise some of the conformances of `WindowsBool` to not be available without reflection or on embedded. This matches how `DarwinBoolean` is handled.
These constants should be freely inlined as they are simply casts or redeclarations of macros which are not importable due to the "complex" nature of them (they involve casts or otherwise non-integral constants).
|
@swift-ci please smoke test |
compnerd
commented
Feb 21, 2025
|
|
||
| extension WindowsBool : CustomStringConvertible { | ||
| @_unavailableInEmbedded |
There was a problem hiding this comment.
Just keeping up with DarwinBoolean. I don't think that WinSDK is particularly useful with "embedded" yet. In theory, we could support IoT with the Windows IoT, but that is largely untested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the WinSDK module some for allowing building without reflection or in embedded (just for matching the Darwin platform overlay rather than for actual purpose).
Thanks to @grynspan for the discussion around this cleanup.