Skip to content

[cxx-interop] Prevent usage in Swift of C++ move constructor with default args #79542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[cxx-interop] Prevent usage in Swift of C++ move constructor with default args #79542

merged 1 commit into from
Mar 7, 2025

Conversation

susmonteiro
Copy link
Contributor

@susmonteiro susmonteiro commented Feb 21, 2025 •
edited
Loading

While support for C++ move constructors with default args in Swift isn't added, we don't import these move constructors to Swift.

@susmonteiro susmonteiro added the c++ interop Feature: Interoperability with C++ label Feb 21, 2025
@susmonteiro susmonteiro changed the title Prevent usage in Swift of C++ move constructor with default args [cxx-interop] Prevent usage in Swift of C++ move constructor with default args Feb 21, 2025
@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from 89cdb01 to 5a10959 Compare February 24, 2025 14:42
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from 5a10959 to b6c1ebb Compare February 24, 2025 16:14
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch 3 times, most recently from b30c0c6 to 73713d8 Compare March 6, 2025 12:01
@susmonteiro susmonteiro marked this pull request as ready for review March 6, 2025 12:02
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

egorzhdan
egorzhdan reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of minor comments.

@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from 73713d8 to 8a1e620 Compare March 6, 2025 14:51
j-hui
j-hui approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@j-hui j-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM other than a refactoring change.

Just to double check, when you say "make them unavailable" are you talking about not importing them, or importing them with an @available() attribute marking them as always unavailable? If the former, can you clarify that in your commit messages?

@susmonteiro
Copy link
Contributor Author

Just to double check, when you say "make them unavailable" are you talking about not importing them, or importing them with an @available() attribute marking them as always unavailable? If the former, can you clarify that in your commit messages?

First option! I will make it more clear, thanks

@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from 8a1e620 to 0b83c84 Compare March 6, 2025 18:06
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from 0b83c84 to d79df87 Compare March 7, 2025 11:16
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

egorzhdan
egorzhdan reviewed Mar 7, 2025
View reviewed changes
@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from d79df87 to dce2af0 Compare March 7, 2025 12:36
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/move-constructor-default-args branch from dce2af0 to 51357a9 Compare March 7, 2025 16:02
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro enabled auto-merge March 7, 2025 17:12
@susmonteiro susmonteiro merged commit 1fc5a4e into main Mar 7, 2025
3 checks passed
@susmonteiro susmonteiro deleted the susmonteiro/move-constructor-default-args branch March 7, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazax-hun Xazax-hun Xazax-hun approved these changes

@egorzhdan egorzhdan egorzhdan approved these changes

@j-hui j-hui j-hui approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@eeckstein eeckstein Awaiting requested review from eeckstein

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@susmonteiro @Xazax-hun @egorzhdan @j-hui