-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ClangImporter][Swiftify] merge importBoundsAttributes with importSpanAttributes and support lifetime bounds for __counted_by #79552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hnrklssn
merged 6 commits into
swiftlang:main
from
hnrklssn:swiftify-span-with-counted-by
Feb 24, 2025
Merged
[ClangImporter][Swiftify] merge importBoundsAttributes with importSpanAttributes and support lifetime bounds for __counted_by #79552
hnrklssn
merged 6 commits into
swiftlang:main
from
hnrklssn:swiftify-span-with-counted-by
Feb 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hnrklssn
commented
Feb 22, 2025
importBoundsAttributes and importSpanAttributes are merged into a single function named swiftify. This allows us to not have to duplicate the effort of attaching _SwiftifyImport macros, but is also necessary to allow importing a function with both __counted_by and std::span types.
This allows combining __counted_by and std::span for safe interop. Previously we disabled this in C++ mode due to issues when bounds attributes occurred directly or indirectly in templated contexts, but this has now been resolved on the clang side.
__counted_by return values with .lifetimeDependence are now mapped to Span instead of UnsafeBufferPointer. Also fixes bug where std::span return values would map to Span even if lifetime dependence info was missing.
e08f701
to
ad426fb
Compare
@swift-ci please smoke test |
1 similar comment
@swift-ci please smoke test |
@swift-ci please smoke test |
Looks like there are some test failures on Windows for some reason. Can you look into that? |
Xazax-hun
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, commented some nits.
Xazax-hun
approved these changes
Feb 24, 2025
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.